...I can log in but when I double click on a server its an instant crash to desktop...
I developed this problem the other day after uninstalling EA's Easyinfo 3 utility (Fuck you...fuck you very much, EA
). As well as the CTD, when I put the BF2 CD in the drive it would start the installer.
Turns out the little bastard wiped the whole
HKLM\SOFTWARE\Electronic Arts\EA Games folder in my registry (it contains the games CD key info). I undid the damage by using System Restore.
Obviously, when you insert the CD or try to join a server, they both look for the key info in the registry. If it isn't there, the CD starts the installer and the servers boot you because they think it's a pirate copy. SP mustn't check or it'd crash too.
In your case, you've got a new registry and unless you can modify it to add the CD key, you'll have to reinstall.